Fix docstring for connectivity parameter in watershed function. #7360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While investigating the watershed implementation these days, I noticed that the docstring for
connectivity
was a bit off: In the function signature, we haveconnectivity=1
and thenconnectivity : ndarray, optional
...It turns out we use a
connectivity
parameter in many functions across the library, many of which usescikit-image/skimage/morphology/_util.py
Line 8 in 9e8bf68
internally, which itself relies on scipy's generate_binary_sctructure. There's definitely room for standardization here, but I'll start with just the instance in
watershed
.I've drawn from the docstring in
_validate_connectivity
(above).@stefanv since this PR is docs-only, maybe it could go into v0.23?
Checklist
./doc/examples
for new featuresRelease note
We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.