Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring for connectivity parameter in watershed function. #7360

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mkcor
Copy link
Member

@mkcor mkcor commented Mar 27, 2024

Description

While investigating the watershed implementation these days, I noticed that the docstring for connectivity was a bit off: In the function signature, we have connectivity=1 and then connectivity : ndarray, optional...

It turns out we use a connectivity parameter in many functions across the library, many of which use

def _validate_connectivity(image_dim, connectivity, offset):

internally, which itself relies on scipy's generate_binary_sctructure. There's definitely room for standardization here, but I'll start with just the instance in watershed.

I've drawn from the docstring in _validate_connectivity (above).

@stefanv since this PR is docs-only, maybe it could go into v0.23?

Checklist

Release note

We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.

Fix docstring of `connectivity` parameter in `skimage.segmentation.watershed`.

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Mar 27, 2024
@lagru
Copy link
Member

lagru commented Apr 4, 2024

@stefanv since this PR is docs-only, maybe it could go into v0.23?

Did I miss the announced feature freeze or is this implicit. It's probably wise to do not add new features, but documentation and simple maintenance changes are probably fine...?

@lagru
Copy link
Member

lagru commented Apr 4, 2024

I think since we are no longer really using release branches we haven't really communicated about a new workflow around releases.

@lagru lagru added the 🚀 Quick win Trivial, small or easy to address or review label Apr 4, 2024
@mkcor
Copy link
Member Author

mkcor commented Apr 4, 2024

Did I miss the announced feature freeze or is this implicit?

Same question here.

It's probably wise to do not add new features, but documentation and simple maintenance changes are probably fine...?

I would also think so.

@jarrodmillman jarrodmillman merged commit 23a97f0 into scikit-image:main Apr 11, 2024
25 of 26 checks passed
@stefanv stefanv added this to the 0.23.2 milestone Apr 11, 2024
@mkcor mkcor deleted the fix-docs-connectivity branch April 15, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation 🚀 Quick win Trivial, small or easy to address or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants