Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add out-of-tree Pyodide builds in CI for scikit-image #7350

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Add out-of-tree Pyodide builds in CI for scikit-image #7350

wants to merge 39 commits into from
+360 −4

Commits on Mar 18, 2024

  1. Test emscripten workflow inspired by NumPy 

    Initial inspiration was taken from
numpy/numpy#24603.
    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    12a2aec View commit details
    Browse the repository at this point in the history

  2. Remove NumPy specific configuration

    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    139c62d View commit details
    Browse the repository at this point in the history

  3. Try out pyodide 0.25.0a2 

    Locally, this version seems to successfully create a wheel when running
"pyodide build" opposed to using "python -m build ...".
    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7969f4a View commit details
    Browse the repository at this point in the history

  4. Use correct file name for test requirements

    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1fec286 View commit details
    Browse the repository at this point in the history

  5. Specify test requirements without missing asv

    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5cc0762 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary emscripten.meson.cross

    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dc1e3bc View commit details
    Browse the repository at this point in the history

  7. Account for unsupported subprocess

    @lagru @agriyakhetarpal
    lagru authored and agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    929dbcf View commit details
    Browse the repository at this point in the history

  8. Update Emscripten build workflow and actions 

    Based on numpy/numpy#25894. This comment updates versions for Pyodide, Emscripten, and improves some names for job steps. Multiple reusable actions have also been updated in accordance with the latest versions available.

Co-Authored-By: Lars Grüter <20140352+lagru@users.noreply.github.com>
    @agriyakhetarpal @lagru
    agriyakhetarpal and lagru committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7a90748 View commit details
    Browse the repository at this point in the history

  9. Change and reformat all .npy files to .npz 

    This commit loads and re-saves all of the `.npy` files to `.npz` NumPy compressed file format and saves them to the 'data' field in the Npz objects.

The test cases where they have been used have been updated to use this attribute, and the SHA-256 checksums in the registry for each of the files have been updated in accordance with this change.
    @agriyakhetarpal
    agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0dc7431 View commit details
    Browse the repository at this point in the history

  10. Skip downloading files from pooch for now

    @agriyakhetarpal
    agriyakhetarpal committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    01c61ba View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Add JS script to run pytest test suite

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    360e48a View commit details
    Browse the repository at this point in the history

  2. Run and debug JS script for Emscripten job

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    12f0bd4 View commit details
    Browse the repository at this point in the history

  3. Run parallelized tests in serial mode on WASM

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b529673 View commit details
    Browse the repository at this point in the history

  4. Skip test that requires reading from HTTP on WASM

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2adf430 View commit details
    Browse the repository at this point in the history

  5. Skip test for @run_in_parallel decorator

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9afa53a View commit details
    Browse the repository at this point in the history

  6. Add threading import and usage guards

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    fa3154e View commit details
    Browse the repository at this point in the history

  7. Skip all Matplotlib-related tests

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ee9dbc2 View commit details
    Browse the repository at this point in the history

  8. Move IS_WASM check to correct location

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    46fa541 View commit details
    Browse the repository at this point in the history

  9. Properly guard threading for multiscale features

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2c00ec5 View commit details
    Browse the repository at this point in the history

  10. Set Agg Matplotlib backend via environment variable 

    Try setting Agg backend for Matplotlib testing

Don't mark Matplotlib tests, correct set backend
    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    fe1777d View commit details
    Browse the repository at this point in the history

  11. Add a patch to fix NumPy array FS access

    @agriyakhetarpal
    agriyakhetarpal committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b55ae6f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Apply patch to Emscripten SDK at build time

    @agriyakhetarpal
    agriyakhetarpal committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    24598b7 View commit details
    Browse the repository at this point in the history

  2. Revert "Change and reformat all .npy files to .npz" 

    This reverts commit 0dc7431.
    @agriyakhetarpal
    agriyakhetarpal committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c995211 View commit details
    Browse the repository at this point in the history

  3. Fix patch

    @agriyakhetarpal
    agriyakhetarpal committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c587e5c View commit details
    Browse the repository at this point in the history

  4. Perform some cleanups

    @agriyakhetarpal
    agriyakhetarpal committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    be525a4 View commit details
    Browse the repository at this point in the history

  5. Try using Agg backend programmatically

    @agriyakhetarpal
    agriyakhetarpal committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f466193 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Merge branch 'main' into add-emscripten-builds-out-of-tree

    @agriyakhetarpal
    agriyakhetarpal committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e4cc188 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. Merge branch 'main' into add-emscripten-builds-out-of-tree

    @agriyakhetarpal
    agriyakhetarpal committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    37364b2 View commit details
    Browse the repository at this point in the history

  2. Bump Pyodide version 

    See pyodide/pyodide#4654 for discussion. This commit resolves a build error due
to a release of `build` (v1.2.0) which had broken the
`pyodide build` command for all repositories.
    @agriyakhetarpal
    agriyakhetarpal committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    d02105b View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'main' into add-emscripten-builds-out-of-tree

    @agriyakhetarpal
    agriyakhetarpal committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    88903e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Rewrite statement control flow for is_wasm check

    @agriyakhetarpal
    agriyakhetarpal committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0b1c933 View commit details
    Browse the repository at this point in the history

  2. Add licensing details for skimage JS test runner

    @agriyakhetarpal
    agriyakhetarpal committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    19159a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Remove MPLBACKEND env var from test step

    @agriyakhetarpal
    agriyakhetarpal committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    174f3e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into add-emscripten-builds-out-of-tree

    @agriyakhetarpal
    agriyakhetarpal committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1df1753 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Return even earlier in run_in_parallel on WASM

    @lagru
    lagru committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e94b1cd View commit details
    Browse the repository at this point in the history

  2. Mock ThreadPoolExecutor on WASM

    @lagru
    lagru committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    cdd9830 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'main' into add-emscripten-builds-out-of-tree

    @agriyakhetarpal
    agriyakhetarpal committed May 21, 2024
    Configuration menu
    Copy the full SHA
    06230bd View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Merge branch 'main' into add-emscripten-builds-out-of-tree

    @agriyakhetarpal
    agriyakhetarpal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e177755 View commit details
    Browse the repository at this point in the history

  2. Bump to Pyodide version 0.26.0

    @agriyakhetarpal
    agriyakhetarpal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a6754d5 View commit details
    Browse the repository at this point in the history