Replace deprecated nose style setup/teardown with autouse fixtures #7343
Conversation
methods with autouse fixtures. The nose style is no longer supported by pytest since version 7.2. https://docs.pytest.org/en/latest/deprecations.html#nose-deprecation
in rank/tests. These are called in skimage/conftest.py already and I don't see a reason to call them again in rank/tests specifically..
lagru
added
🔧 type: Maintenance
|
|
||
|
|
||
| def setup(): | ||
| @pytest.fixture(autouse=True) | ||
| def _use_imread_plugin(): |
There was a problem hiding this comment.
Disclaimer: non-expert here 😉 Just curious, from reading the documentation you linked to, I was expecting some def setup() to be replaced by def setup_method() (while the fixture is recommended for replacing code using @with_setup)...(?)
There was a problem hiding this comment.
Ah, I didn't know that pytest supports another approach to achieve this. 😅 Though, in this case it should be setup_module and teardown_module.
Looks like both approaches are valid but I feel like the fixture based one may the better known approach and is also the one recommended by pytest. And that I feel more comfortable with the fixture based approach may also be a factor. ^^
|
Merging since it seems there's a silent consensus and at least 2 approving maintainers. :) |
Description
Follow-up to #7340.
Pytest has deprecated nose style setup and teardown since 7.2.
https://docs.pytest.org/en/latest/deprecations.html#nose-deprecation
Checklist
./doc/examplesfor new featuresRelease note
We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.