Address new copy semantics & broadcasting in np.solve in NumPy 2
#7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With NumPy 2.0.0, `copy=False` now raises a ValueError if the copy cannot be made. The previous behavior to only copy if needed is provided with `copy=None`. During the transition period, use this symbol instead. Remove once NumPy 2.0.0 is the minimal required version [1, 2] This approach was inspired by astropy [3]. [1] https://numpy.org/devdocs/release/2.0.0-notes.html#new-copy-keyword-meaning-for-array-and-asarray-constructors [2] https://www.github.com/numpy/numpy/pull/25168 [3] https://github.com/astropy/astropy/blob/2390bf8f8f2a1c5b6beffbd87db9af5aa6538df1/astropy/utils/compat/numpycompat.py#L29
"The broadcasting rules for `np.solve(a, b)`` were ambiguous when b had 1 fewer dimensions than `a`. This has been resolved in a backward- incompatible way and is now compliant with the Array API. The old behaviour can be reconstructed by using `np.solve(a, b[..., None])[..., 0]`." https://numpy.org/devdocs/release/2.0.0-notes.html#removed-ambiguity-when-broadcasting-in-np-solve https://www.github.com/numpy/numpy/pull/25914
lagru
changed the title
NP_COPY_IF_NEEDED for compatibility with new NumPy 2 copy semanticsnp.solve in NumPy 2
stefanv
approved these changes
Mar 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With NumPy 2.0.0,
copy=Falsenow raises a ValueError if the copy cannot be made innumpy.asarrayandnumpy.array, see the release notes for details. I'm using an approach by astropy to address this.Additionally, broadcasting in
np.linalg.solveis now handled differently in a backwards-incompatible way, see release notes on the recommended fix.Checklist
./doc/examplesfor new featuresRelease note
We use changelist to
compile each pull request into an item of the release notes. Please refer to
the instructions
and past release notes
for guidance and examples.