Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docstring to each individual function #7277

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Ganesh2409
Copy link

@Ganesh2409 Ganesh2409 commented Dec 23, 2023

Description

Updated Documentation of adapt_rgb.py by adding docstring for each functions

Fixes: #7270

  • I have added the "image" parameter as an array and highlighted the additional arguments (*args, **kwargs) that can be passed to the underlying image filter function into Docstring

  • The docstring now explains that if the image is RGB-like, the apply_to_rgb function is used to apply the filter. Otherwise, the image filter is applied directly.

@mkcor mkcor added the 📄 type: Documentation Updates, fixes and additions to documentation label Dec 23, 2023
@Ganesh2409
Copy link
Author

@mkcor can u please assist me with the faling job .... :)

@Ganesh2409
Copy link
Author

@lagru can you please assist me on this issue...:)

@lagru
Copy link
Member

lagru commented Dec 29, 2023

Hey @Ganesh2409, this already looks much better; thank you. The CI is currently failing because the updated code in this PR doesn't pass the check of our code formatter.

Please have a look at our contribution guide on how to setup the pre-commit hook so that future commits are formatted automatically. After you've done so run:

pre-commit run --all

which should format your code correctly. Then commit the fixes and push to this branch. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 type: Documentation Updates, fixes and additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docstring of color.hsv_value is incomplete
3 participants