Sorting the coordinates of draw.ellipse #7232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagru
reviewed
Nov 8, 2023
Comment on lines
+527
to
+533
| # sorting on the basis of angle | ||
| rr = np.array(rr, dtype=np.intp) | ||
| cc = np.array(cc, dtype=np.intp) | ||
| angle = np.argsort(np.arctan2(cc-np.mean(cc),rr-np.mean(rr))) | ||
| rr = np.take(rr, angle, axis=0) | ||
| cc = np.take(cc, angle, axis=0) | ||
|
|
There was a problem hiding this comment.
Hey @anamfatima1304, thanks for working on this! In case you are not aware, this fails because this file is written in Cython. Similar to C, the variables rr and cc were declared with cdef list rr = ... so you can't assign an array to them because it is a different type.
Instead I would propose that you move this snippet to the Python level in ellipse_perimeter.
|
Hi @anamfatima1304, don't hesitate to reach out if you need help with this PR! |
|
Hey @anamfatima1304, are you planning to pick this up again? If not that's totally okay and someone else could continue the work! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7206
This PR sorts the coordinates of the draw.ellipse by default on the basis of angles.