Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen for sphinx warnings in nightly CI jobs #7227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lagru
Copy link
Member

@lagru lagru commented Oct 27, 2023

Description

... instead of on Azure. I feel like this is the better place to catch warnings early.

The failure addressed by #7226 prompted this change.

Checklist

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically:

...

instead of using Azure. I feel like this is the better place to catch
warnings early.
@lagru lagru added the 🤖 type: Infrastructure CI, packaging, tools and automation label Oct 27, 2023
@stefanv
Copy link
Member

stefanv commented Oct 27, 2023

I think this would be an improvement. But who gets notified of nightly failures, and how?

@lagru
Copy link
Member Author

lagru commented Oct 29, 2023

But who gets notified of nightly failures, and how?

The "Test Nightly" job is triggered on pushes to main. So the core dev creating the merge should be notified explicitly. And a failure should be somewhat visible on our main GitHub page.

It's not ideal but I think we discussed this problem somewhere earlier and found this to be the best solution. We could look into creating an issue automatically on failure?

@lagru lagru marked this pull request as ready for review October 29, 2023 16:48
@stefanv
Copy link
Member

stefanv commented Oct 29, 2023

Yes, I think that's the solution!

@lagru
Copy link
Member Author

lagru commented Oct 29, 2023

Yes, I think that's the solution!

Which one? The "raise an issue" one?

@stefanv
Copy link
Member

stefanv commented Oct 29, 2023

Yes, because I don't think the notification route is very clear otherwise.

Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this one and create an issue so we don't forget to set up the automatic issue creation upon failure of the "Test Nightly" job 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants