Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added harmonic filter #7179

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheLittleChosenOne
Copy link

Description

Checklist

Release note

Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically:

...

@mkcor
Copy link
Member

mkcor commented Oct 10, 2023

Dear @TheLittleChosenOne,

Thank your for your contribution. It looks like you are implementing a new feature; is there a related feature request in the open issues? It would be great if you could share your use case for this filter.

If we choose to support this new feature, we would need to add tests for the function and create a gallery example (based on your use case?). Thanks again.

@TheLittleChosenOne
Copy link
Author

Hello mkcor,

I will be honest and tell you that I found this project and found it very interesting and made a contribution as one of my HW assignments. I am not sure if I am allowed to share the use case for this filter. By all means if this contribution is going to help then you can add it and make which ever test cases you can if it will help the project.

Thanks

@stefanv
Copy link
Member

stefanv commented Oct 14, 2023

Thanks for the contribution @TheLittleChosenOne.

This is presumably the Harmonic mean filter. You can see an example of its application (from the Gonzales & Woods textbook) in these slides.

I am not sure these filters are used much in practice? We could consider adding it if there's a demonstration of need—they are fairly straightforward to implement. The implementation here would need to be changed, though, since it assumes a fixed mask size and iterates over elements in a double for-loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants