Commits on Sep 29, 2023

1. Make unwrap_phase fail for NaN input …

   It seems that the infinite loop happens inside the function `partition`
   which never exits due to `pivot` being NaN. So check `pivot` before
   passing it to that function and return error codes up the call stack
   until we can raise a proper Python exception.
   
   Not sure if that is the best way to address the problem. I understand
   little of what's going on, but it's better than hanging with one core
   stuck at 100%. Performance wise I didn't see any significant impact for
   the following snippet taken from plot_phase_unwrap.py:
   
   ```python
   import numpy as np
   from skimage import data, img_as_float, color, exposure
   from skimage.restoration import unwrap_phase
   image = color.rgb2gray(img_as_float(data.chelsea()))
   image = exposure.rescale_intensity(image, out_range=(0, 4 * np.pi))
   image_wrapped = np.angle(np.exp(1j * image))
   
   %timeit unwrap_phase(image_wrapped)
   ```

   

   lagru committed Sep 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 2079e2e
   • Browse repository at this point

   Copy the full SHA

   2079e2e View commit details

   Browse the repository at this point in the history