-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docstring (missing minus sign) for EuclideanTransform
.
#7097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Happy with either way to format whitespace. :) Thanks Marianne.
I think the |
The |
The I have reverted 5e8e1a8 where I had right-aligned two matrices. I'm not sure how I should left-align [[a0 -b0 a1]
[b0 a0 b1]
[0 0 1]] though. Either [[a0 -b0 a1]
[b0 a0 b1]
[0 0 1]] where the matrix elements are left-aligned, period, or [[a0 -b0 a1]
[b0 a0 b1]
[0 0 1 ]] to preserve the array structure? Thanks. |
I think Stéfan was suggesting something like this 🤷 (aligned on letter / number, sign is ignored):
|
Thanks, I wouldn't have guessed.
Ok, done f662e90. |
@lagru should I label this PR 'quick win' or milestone 0.23? |
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
"Quick win" would have been appropriate I think. But I'll just merge this now, as it has been open for some time with no open concerns. It's also minor and easy to revert. |
This way it also goes into v0.23. @jarrodmillman, let me know if I should have postponed this until after the release and I'll do so in the future with similar cases. |
Description
This is a tiny follow-up on #6840 (comment).
Not sure about 5e8e1a8: I have right-aligned the matrix coefficients because I find it more readable, but I noticed that, in the docstring for
ProjectiveTransform
, they seem centred rather than right-aligned or left-aligned...Closes #7380.
Checklist
./doc/examples
for new featuresRelease note
Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically: