Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: sort draw.ellipse coordinates by default to make sure they are all contiguous #7206

Open
jni opened this issue Oct 16, 2023 · 7 comments · May be fixed by #7232
Open

Proposal: sort draw.ellipse coordinates by default to make sure they are all contiguous #7206

jni opened this issue Oct 16, 2023 · 7 comments · May be fixed by #7232
Labels
🔰 Good first issue 🙏 Feature request

Comments

@jni
Copy link
Member

jni commented Oct 16, 2023

Description:

Someone just upvoted this old SO answer of mine:

https://stackoverflow.com/questions/62339802/skimage-draw-ellipse-generates-two-undesired-lines

Basically, using plt.plot or any other line drawing software to draw an ellipse from our ellipse coordinates fails because of how the coordinates are sorted (or rather, not sorted):

The solution is to sort the coordinates based on the angle around the centroid. It's easy/fast enough and would make downstream work simpler, plus I think it's what most users would expect.
@lagru
Copy link
Member

lagru commented Oct 17, 2023

Seems very sensible. 👍

@anamfatima1304
Copy link
Contributor

Hey @jni I read the problem thoroughly. Can I open a pull request that sorts the coordinates based on the angle?

@jni
Copy link
Member Author

jni commented Nov 1, 2023

@anamfatima1304 go for it! Thanks!

@anamfatima1304 anamfatima1304 linked a pull request Nov 4, 2023 that will close this issue
Open
@RitikaxShakya
Copy link

Hello! May i know if anyone is working on this issue? if not may i pick this issue?

@lagru
Copy link
Member

lagru commented Feb 22, 2024

hey @RitikaxShakya, this has been taken up in #7232. Though, it seems that work on has stalled a bit. Let's wait a few days to see if @anamfatima1304 wants to pick it up again. Otherwise feel welcome to open a PR in let's say 1 week. :D

@lagru
Copy link
Member

lagru commented Mar 16, 2024

Hey @RitikaxShakya, if you are still interested, I've marked #7232 as ready to take over. 🙏

@RitikaxShakya
Copy link

@lagru Cool! I will take up this issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔰 Good first issue 🙏 Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sorting the coordinates of draw.ellipse anamfatima1304/scikit-image
4 participants
@jni @lagru @RitikaxShakya @anamfatima1304