Skip to content

Commit

Permalink
Revert to older artifacat uploader and downloader
Browse files Browse the repository at this point in the history
action/artifact-uploader@v4 has this breaking change:
```
Uploading to the same named Artifact multiple times.

Due to how Artifacts are created in this new version, it is no longer
possible to upload to the same named Artifact multiple times. You must
either split the uploads into multiple Artifacts with different names,
or only upload once. Otherwise you will encounter an error.
```
  • Loading branch information
jarrodmillman committed Apr 10, 2024
1 parent 51c47c9 commit 6a60e5b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ jobs:
if: always()
run: cp benchmarks/README_CI.md benchmarks.log .asv/results/

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
if: always()
with:
name: asv-benchmark-results-${{ runner.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
DEPLOY_KEY: ${{ secrets.DOC_DEPLOY_KEY_PRIVATE }}
GIT_SSH_COMMAND: "ssh -o StrictHostKeyChecking=no"
- name: Store docs as artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: docs
path: doc/build/html
2 changes: 1 addition & 1 deletion .github/workflows/nightly_wheel_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
if: github.repository_owner == 'scikit-image' && github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
id: download
with:
name: wheels
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wheel_tests_and_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
run: |
pip install twine
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3
id: download
with:
name: wheels
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/wheels_recipe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
CIBW_MANYLINUX_I686_IMAGE: ${{ matrix.cibw_manylinux }}
CIBW_ENVIRONMENT_PASS_LINUX: SKIMAGE_LINK_FLAGS
SKIMAGE_LINK_FLAGS: "-Wl,--strip-debug"
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: wheels
path: ./dist/*.whl
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
CIBW_MANYLINUX_I686_IMAGE: ${{ matrix.cibw_manylinux }}
CIBW_ENVIRONMENT_PASS_LINUX: SKIMAGE_LINK_FLAGS
SKIMAGE_LINK_FLAGS: "-Wl,--strip-debug"
- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: wheels
path: ./dist/*.whl
Expand Down Expand Up @@ -177,7 +177,7 @@ jobs:
CIBW_MANYLINUX_I686_IMAGE: manylinux1
CIBW_TEST_SKIP: "*-macosx_arm64"

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: wheels
path: ./dist/*.whl
Expand Down Expand Up @@ -235,7 +235,7 @@ jobs:
# -Wl,-S equivalent to gcc's -Wl,--strip-debug
LDFLAGS: "-Wl,-S"

- uses: actions/upload-artifact@v4
- uses: actions/upload-artifact@v3
with:
name: wheels
path: ./dist/*.whl

0 comments on commit 6a60e5b

Please sign in to comment.