Delete old content and replace with basic skeleton #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodmillman
requested review from
rgommers
and removed request for
stefanv and
MridulS
jarrodmillman
force-pushed
the
spec2
branch
2 times, most recently
from
1bbaaab
to
2772ec1
Compare
tupui
approved these changes
Jun 5, 2024
Comment on lines
+25
to
+35
| ### Core Project Endorsement | ||
|
|
||
| <!-- | ||
| Briefly discuss what it means for a core project to endorse this SPEC. | ||
| --> | ||
|
|
||
| ### Ecosystem Adoption | ||
|
|
||
| <!-- | ||
| Briefly discuss what it means for a project to adopt this SPEC. | ||
| --> |
There was a problem hiding this comment.
Non blocking comment: we were discussing that maybe these don't have to be in the skeleton. Endorsement and adoption is defined globally for all SPECs and should mostly be the same. Hence, unless there is a distinction specific to this SPEC which needs to be made, I would remove these sections.
There was a problem hiding this comment.
@tupui Do you mind filing this as an issue for discussion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #229.