Add support for externally hosted calendars #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scientific-python-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Use a different compile path for local and remotely stored calendars - Render external links on the calendar download page, but use internal links for JS calendar displayt - Add Pandas's calendar
stefanv
force-pushed
the
build-external-calendars-too
branch
from
8d92254
to
0b4da12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@melissawm This is the alternative pathway I had in mind for scientific-python/yaml2ics#71 and #246
The one problem with this approach (and any approach, in fact) is that our calendar rendering won't update when pandas changes their ICS. I tried to make the widget render from the remote URL, but that causes CORS problems.
Given that their calendar may frequently be out of date, does it make sense to host it here—or at least, include it in the calendar widget? Is there a reason why they don't want to use the YAML infrastructure provided?