Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linking to key features #72

Closed
wants to merge 4 commits into from
Closed

Add linking to key features #72

wants to merge 4 commits into from

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Nov 10, 2021 •
edited

When a key feature has a link it will:

  • Light up when hovering over it
  • Have an animated line underneath it
  • Have a clickable (hand) pointer

The other cards will be static.

Closes #69

@stefanv
Add linking to key features
20b1eed 
When a key feature has a link it will:

- Light up when hovering over it
- Have an animated line underneath it
- Have a clickable (hand) pointer

The other cards will be static.
@netlify
Copy link

netlify bot commented Nov 10, 2021 •
edited

✔️ Deploy Preview for scientific-python-hugo-theme ready!

🔨 Explore the source changes: 1475fc7

🔍 Inspect the deploy log: https://app.netlify.com/sites/scientific-python-hugo-theme/deploys/62284601cddd25000889ad55

😎 Browse the preview: https://deploy-preview-72--scientific-python-hugo-theme.netlify.app

@stefanv stefanv mentioned this pull request Nov 10, 2021
Open
@rossbar rossbar mentioned this pull request Nov 10, 2021
Open
rossbar
rossbar approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out in rossbar/manual.scientific-python.org-hugo#5 (haven't setup preview yet) and it works exactly as I'd hoped. Tested there with a relative URL to an internal page to compliment the example here with the external link - works as expected 🚀

@stefanv
Copy link
Member Author

stefanv commented Feb 10, 2022

We don't have a use-case for this now, so closing until it comes up again.

@stefanv stefanv closed this Feb 10, 2022
@jarrodmillman jarrodmillman reopened this Mar 9, 2022
@jarrodmillman jarrodmillman marked this pull request as draft March 9, 2022 01:15
@jarrodmillman
Copy link
Member

I have a potential use case, so want to check this out. May want slightly different look / behavior. Will add more later.

@jarrodmillman
Copy link
Member

See #147.

@jarrodmillman
Copy link
Member

See scientific-python/learn.scientific-python.org#3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Make "keyfeatures" cards linkable
3 participants
@stefanv @jarrodmillman @rossbar