Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make "keyfeatures" cards linkable #69

Open
rossbar opened this issue Nov 9, 2021 · 5 comments
Open

Feature Request: Make "keyfeatures" cards linkable #69

rossbar opened this issue Nov 9, 2021 · 5 comments
Assignees

Comments

@rossbar
Copy link
Member

rossbar commented Nov 9, 2021

I think it would be a nice feature to allow the keyfeatures cards to link to other internal or external pages.

The hugo fresh theme has something similar: see the cards under the "Great Power Comes" section: https://hugo-fresh.vercel.app/ (though I think making the entire card clickable is preferable to adding a button; this is a minor detail though).

@stefanv
Copy link
Member

stefanv commented Nov 10, 2021

See #72

@alphapapa
Copy link
Contributor

alphapapa commented Apr 26, 2023

@rossbar AFAICT this was addressed in the linked PRs, so I'm closing this issue. Please let me know if anything remains to be done and this should be reopened, or feel free to file a new issue and tag me in it. Thanks.

@stefanv
Copy link
Member

stefanv commented Apr 26, 2023

Let's just double check to make sure this feature is documented. The buttons on theme.scientific-python.org are not linkable, so we don't have an obvious example in place.

@rossbar
Copy link
Member Author

rossbar commented Apr 26, 2023

FWIW this hasn't quite been resolved, at least in terms of anchor links for the headings.

For example - if you look at the deployed site the heading titles are still not anchor links. #72 improved the situation by adding the side navbar, but I think there's still value in having the headings be anchor links (mostly for sharing links).

@rossbar rossbar reopened this Apr 26, 2023
@alphapapa
Copy link
Contributor

@stefanv @rossbar Thanks. Assigning to myself and will investigate.

@alphapapa alphapapa self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants