Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty code #621

Draft
wants to merge 18 commits into
base: kstrauser/pyproject
Choose a base branch
from
Draft

Pretty code #621

wants to merge 18 commits into from

Conversation

kstrauser
Copy link
Contributor

I wanted to make the code prettier and more editor-friend. This PR:

  • Uses Black to format the code
  • Uses isort to sort the imports at the top of each module
  • Updates the type hints so that mypy passes cleanly
  • Removes almost all wildcard imports (which helps editors better know where names are defined)
  • Found a test (see f92b887) that had been nested inside another, and therefore hadn't run, in about 8 years!
  • Cleaned up a lot of pylint and flake8 warnings and errors, but tried not to go too far down that rabbit hole

I think the end result looks nice and modern. 馃檪

This builds on #620 and shouldn't be merged until that one is, and then after rebasing.

@kstrauser kstrauser added the do not merge This PR isn't ready to be merged yet label Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge This PR isn't ready to be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant