Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework email validation regex #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sotanodroid
Copy link

@sotanodroid sotanodroid commented Jul 21, 2020

There is a couple of emails that I found invalid but Schematics validator passed them as OK.
Examples are: with/slash@gmail.com, ivan.***@mail.ru, d|vor@mail.ru

Symbols | / and ' are commonly used delimiters and many services such as Gmail not allowing them

Changed: email validation regex
Add: unittests

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #612 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          24       24           
  Lines        2541     2541           
=======================================
  Hits         2314     2314           
  Misses        227      227           
Impacted Files Coverage Δ
schematics/types/net.py 93.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90dee53...67f9a07. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants