-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed usages of deprecated fields #595
base: master
Are you sure you want to change the base?
Conversation
Refs Issue-571
Refs I-571
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 91.06% 90.38% -0.69%
==========================================
Files 24 24
Lines 2541 2547 +6
==========================================
- Hits 2314 2302 -12
- Misses 227 245 +18
Continue to review full report at Codecov.
|
4 similar comments
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 91.06% 90.38% -0.69%
==========================================
Files 24 24
Lines 2541 2547 +6
==========================================
- Hits 2314 2302 -12
- Misses 227 245 +18
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 91.06% 90.38% -0.69%
==========================================
Files 24 24
Lines 2541 2547 +6
==========================================
- Hits 2314 2302 -12
- Misses 227 245 +18
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 91.06% 90.38% -0.69%
==========================================
Files 24 24
Lines 2541 2547 +6
==========================================
- Hits 2314 2302 -12
- Misses 227 245 +18
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 91.06% 90.38% -0.69%
==========================================
Files 24 24
Lines 2541 2547 +6
==========================================
- Hits 2314 2302 -12
- Misses 227 245 +18
Continue to review full report at Codecov.
|
+1 from me to get this or a similar fix merged. This greatly reduces the number of deprecation warning I see in my schematics project. (Still have one call to deprecated function fields, from deprecated.py line 65.) |
Is there a maintainer who can review, merge and release a 2.1.1 if this is okay? |
(preface) Hi o/ not sure if you're looking for PRs in this category of work but I saw #571 and it was annoying me in my builds, so I thought I would try to solve it instead of piling on. That being said, I did a very naive refactor based on what I understood. Ya'll might have had more comprehensive plans about how you wanted to arrange things. But hopefully this is roughly in the ballpark. (/preface)
There were a number of deprecation errors being emitted from the package, so I have attempted to update all those references by essentially taking the wrapping code and moving it closer to the calling site. I did my best with the understanding of the interactions.
I have also added a
Makefile
that makes is easier to set up a dev environment and get tests running. I realize I am imposing this, so let me know if you would rather not have this.Makefile output: