Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Model.import_data for empty dict #584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed Model.import_data for empty dict #584

wants to merge 1 commit into from

Conversation

altvod
Copy link

@altvod altvod commented Feb 6, 2019

If you call Model.import_dict() with a dictionary that is created by some other part of your program, it might be empty, but the import_dict method should still work the same way as it would if the dictionary had any values in it, i.e. convert only the incoming data (of which there isn't any). Otherwise it leads to data being converted twice, which is unacceptable as it can cause corruption of the stored data.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #584 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   91.06%   91.06%           
=======================================
  Files          24       24           
  Lines        2541     2541           
=======================================
  Hits         2314     2314           
  Misses        227      227
Impacted Files Coverage Δ
schematics/models.py 97.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90dee53...447468e. Read the comment docs.

@lkraider lkraider added this to the 2.2 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants