Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated description of billingPeriod #2688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated description of billingPeriod #2688

wants to merge 3 commits into from

Conversation

RichardWallis
Copy link
Contributor

Added invoiceDate property
Updated examples to reflect changes
Fixes #2210

Added invoiceDate property
Updated examples to reflect changes
Fixes #2210
@danbri
Copy link
Contributor

danbri commented Aug 18, 2020

rdfs:comment "The time interval used to compute the invoice [[paymentDueDate]]." .

Adding a reference to paymentDueDate doesn't make a sentence

@RichardWallis
Copy link
Contributor Author

Updated wording for billingPeriod to:

The time interval used to compute the [[paymentDueDate]] for the invoice.

Copy link

@dr-shorthair dr-shorthair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology is still jumbled here.

  • time-interval = an interval on the time-line with a beginning and end
  • duration = distance or amount of time between two instants or temporal positions
  • period = usually synonym for time-interval

So I would suggest that either the property name or the range needs to be changed:

  • billingPeriodDuration could have range Duration
  • billingPeriod should have range Interval or Period, which in turn should have a intervalDuration or periodDuration property whose range is Duration
    But the proposed state is not coherent.

@github-actions
Copy link

This pull request is being tagged as Stale due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

billingPeriod of type Duration, but represents an Interval
4 participants