-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer scala-cli pragmas [ci: last-only] #10757
base: 2.13.x
Are you sure you want to change the base?
Conversation
f0214ba
to
ad07cf3
Compare
Missed a few pragmas that were slightly irregular. One test failure confused me. It's actually testing that multiple pragmas (on different lines) are picked up, but that was broken. However, it happened to exercise the ambiguity between inherited member and def in scope. I guess it's a warning (2.13.14) that is promoted to error if -Xsource;3, but the message text is the same. But the reference is not ambiguous in the sense of erroneous; it's merely confusing. I'm not sure what I was testing: maybe documenting status quo that "last pragma wins". The companion test shows both options in one pragma (with comma separation). scala-cli appears to accumulate and keep both pragmas, as it errors irrespective of the order of the two pragmas.
|
Goal is to remove the old header parsing.
Global replace changes range positions in output. (Which also change in a recent PR.)
Conversion of
java:
andjavaVersion:
to follow. Edit: uses javaOpt, javacOpt. Edit: also jvm for javaVersion.Edit: remove old header parsing. Remove one usage of
hide:
in favor ofDirectTest
.filter
must be quoted if it has embedded spaces.Follow-up to #10756