Optimize memory consumption of Infos #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the retained size on the test suite for the infos as follows: BaseLinker: 26MB -> 24MB Refiner: 22MB -> 20MB
This avoids unnecessary calls to `addStaticDependency`, but more importantly, it will allow us to flatten the structure of `ReachabilityInfoInClass`.
This allows us to remove a field from `ReachabilityInfoInClass` which reduces the retained size on the test suite for the infos as follows: BaseLinker: 24MB -> 23MB Refiner: 20MB -> 20MB (within rounding error)
|
Analyzer timings (incremental): |
|
Fixed the trailing commas. |
sjrd
approved these changes
Apr 13, 2024
linker/shared/src/main/scala/org/scalajs/linker/analyzer/Infos.scala
Outdated
Show resolved
Hide resolved
This reduces the retained size on the test suite for the infos as follows: BaseLinker: 23MB -> 20MB Refiner: 20MB -> 17MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the retained size on the test suite for the infos as
follows:
The (incremental) runtime of the Analysis is unaffected.