Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-] add sqlalchemy to vdsql requirements.txt #2402

Closed
wants to merge 1 commit into from

Conversation

midichef
Copy link
Contributor

@midichef midichef commented May 4, 2024

This seems to fix the tests breaking for vdsql right now:

Run cd visidata/apps/vdsql && ./test.sh
--- tests/dup-limit.vdj
saul.pw/VisiData v3.1dev
opening tests/dup-limit.vdj as vdj
opening tests/business.sqlite as sqlite
ModuleNotFoundError: No module named 'sqlalchemy'
no "キcustomers" row on business
replay aborted during open-row
Error: Process completed with exit code 1.

saulpw added a commit that referenced this pull request May 16, 2024
…2402

sqlalchemy was removed as dependency in ibis 9.0.  Should fix vdsql build.

This reverts commit 82dbd7f.
@saulpw
Copy link
Owner

saulpw commented May 16, 2024

sqlalchemy was removed in ibis 9.0, so we don't need to import sqlalchemy to handle missing backends anymore.

@saulpw saulpw closed this May 16, 2024
@midichef midichef deleted the vdsql_sqlalchemy branch May 16, 2024 06:34
anjakefala pushed a commit that referenced this pull request May 16, 2024
…2402

sqlalchemy was removed as dependency in ibis 9.0.  Should fix vdsql build.

This reverts commit 82dbd7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants