[main-] remove unneeded reload in batch mode #2361
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch mode (when not replaying commands with
-p
) is substantially slower to load a file than interactive mode.quit.vdj.txt
That's because batch mode runs
reload()
twice in a row in these two lines:visidata/visidata/main.py
Lines 336 to 337 in 581cdf1
vd.push()
callsBaseSheet.ensureLoaded()
which callsreload()
:visidata/visidata/sheets.py
Line 1034 in 581cdf1
visidata/visidata/basesheet.py
Line 272 in 581cdf1
This PR removes the unneeded explicit call to
reload()
, running 2x faster for the special case of no commands.