Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add on paused callback for 'YoutubePlayer' widget #580

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

maherjaafar
Copy link

Add on paused callback for 'YoutubePlayer' widget

@maherjaafar maherjaafar changed the title Feature - Add on paused callback for 'YoutubePlayer' widget [WIP] Feature - Add on paused callback for 'YoutubePlayer' widget Dec 1, 2021
@maherjaafar maherjaafar changed the title [WIP] Feature - Add on paused callback for 'YoutubePlayer' widget Feature - Add on paused callback for 'YoutubePlayer' widget Dec 6, 2021
@sarbagyastha
Copy link
Owner

sarbagyastha commented Dec 14, 2021

There's already a isPlaying flag, why was a callback necessary?

@maherjaafar
Copy link
Author

There's already a isPlaying flag, why was a callback necessary?

I am using Firebase Analytics, and I am checking the position of the video when it's paused. It's more simple to do the job inside onPaused by getting the metadata.

@maherjaafar maherjaafar changed the title Feature - Add on paused callback for 'YoutubePlayer' widget feature: Add on paused callback for 'YoutubePlayer' widget Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants