Pin to ActiveFedora 9.9 #1660
Closed
Pin to ActiveFedora 9.9 #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,7 @@ Gem::Specification.new do |spec| | |||
| spec.add_dependency 'activerecord-import', '~> 0.5' | |||
| spec.add_dependency 'posix-spawn' | |||
| spec.add_dependency 'kaminari_route_prefix' | |||
| spec.add_dependency 'active-fedora', '= 9.9' | |||
There was a problem hiding this comment.
Do you need to pin active-fedora? Couldn't you pin activefedora-aggregations instead?
Or, is it even worth pinning anything? If you're updating dependencies, why would you selectively update sufia and not aggregations?
There was a problem hiding this comment.
Yes, pin to ActiveFedora-aggregations 0.9 instead.
|
Can we close this now? Master is passing. |
|
Closing since it was a temporary hack to get around an error that is no longer occuring. Thanks for reporting this, @hectorcorrea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary hack to prevent issue with
valid_options=in latest version of ActiveFedoraAggregations.@projecthydra/sufia-code-reviewers