[WIP] Collection search builder part2 #1110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atz
force-pushed
the
collection_search_builder_part2
branch
from
ad1126d
to
776875e
Compare
atz
changed the title
jcoyne
requested changes
Nov 29, 2016
| builder.discovery_perms = access_levels[access_level] if access_level | ||
| end | ||
| collections_search_builder_class.new(self, access_levels[access_level]) | ||
| # collections_search_builder_class.new(self, nil).tap do |builder| |
There was a problem hiding this comment.
remove this stuff if it's no longer needed.
| @rows = 100 | ||
| super(context) | ||
| @discovery_permissions ||= access_levels[access] if access |
There was a problem hiding this comment.
@discovery_permissions is always nil here, so why use ||=?
There was a problem hiding this comment.
Not necessarily. If this class is extended and that class' initializer sets the @discovery_permissions before calling this one, then we keep those (e.g. bypassing access_levels). But you are right we can probably do without it.
You can mostly ignore this PR while it is still WIP.
Used to un-protect the method, but no longer needed.
atz
force-pushed
the
collection_search_builder_part2
branch
4 times, most recently
from
5ffbd9a
to
61b8d5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retargeted PR against master after part1 #1105 merged.