v0.21.12 release preparation #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around quality-of-implementation issues in OpenSSL and Apple SecureTransport: they send `server_name` extensions containing IP addresses. RFC6066 specifically disallows that. It is a similar work-around to that adopted by LibreSSL: ignore SNI contents if they can be parsed as an IP address.
I think |
|
Probably okay to bump the MSRV to 1.63 on this branch, too? |
Sure 👍 I can do that and also include a Cargo version bump and we can call this the release prep branch. |
cpu
changed the title
``` error: unnecessary closure used with `bool::then` --> rustls/src/tls13/mod.rs:87:9 | 87 | (prev.hash_algorithm() == self.hash_algorithm()).then(|| prev) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------------- | | | help: use `then_some(..)` instead: `then_some(prev)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations = note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_lazy_evaluations)]` ```
We're seeing more of our deps move to this MSRV or higher (e.g. `webpki`, `rustls-platform-verifier`) and it's shipped in Debian stable. Time to move our MSRV to 1.63.
cpu
force-pushed
the
cpu-rel-0.21-sni-crimes
branch
from
f9f3d0b
to
8c41067
Compare
ctz
approved these changes
Apr 26, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
djc
approved these changes
Apr 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed release notes
Backports #1881 to the rel-0.21 branch.
Code changes in each commit were required to adjust for API differences between the releases.
Hopefully this will help with dart-lang/http#1161 and a couple other instances of folks stuck on 0.21 for various reasons.