Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove unused apt package #8048

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

easymoney322
Copy link
Contributor

Currently there are two overlaping apt metapackages being installed in CI workflows: llvm-dev and llvm-10-dev. Installing both of them increases time for the workflow.
In ubuntu:18.04 (the one is being used in the workflow) llvm-dev is resolved to llvm-6-dev. The difference between installing llvm-dev and llvm-10-dev are these packages:

  • libjsoncpp1(installed only with llvm-dev and I can't seem to find the usage of this package in the code),
  • libllvm10 and libllvm6.0,
  • llvm-10 and llvm-6.0,
  • llvm-10-dev and llvm-6.0-dev,
  • llvm-10-runtime and llvm-6.0-runtime.

You can see that by trying to installing them separately:

root@9b7cdaa9581a:/# apt install llvm-dev
The following additional packages will be installed:
  binfmt-support libedit2 libffi-dev libjsoncpp1 libllvm6.0 libpipeline1 libtinfo-dev llvm llvm-6.0 llvm-6.0-dev
  llvm-6.0-runtime llvm-runtime
Suggested packages:
  llvm-6.0-doc
The following NEW packages will be installed:
  binfmt-support libedit2 libffi-dev libjsoncpp1 libllvm6.0 libpipeline1 libtinfo-dev llvm llvm-6.0 llvm-6.0-dev
  llvm-6.0-runtime llvm-dev llvm-runtime
0 upgraded, 13 newly installed, 0 to remove and 1 not upgraded.
root@9b7cdaa9581a:/# apt install llvm-dev llvm-10-dev
The following additional packages will be installed:
  binfmt-support file libclang-cpp10 libedit2 libexpat1 libffi-dev libgomp1 libjsoncpp1 libllvm10 libllvm6.0
  libmagic-mgc libmagic1 libmpdec2 libpfm4 libpipeline1 libpython3-stdlib libpython3.6-minimal libpython3.6-stdlib
  libreadline7 libsqlite3-0 libssl1.1 libtinfo-dev libyaml-0-2 libz3-4 libz3-dev llvm llvm-10 llvm-10-runtime
  llvm-10-tools llvm-6.0 llvm-6.0-dev llvm-6.0-runtime llvm-runtime mime-support python3 python3-minimal
  python3-pkg-resources python3-pygments python3-yaml python3.6 python3.6-minimal readline-common xz-utils
Suggested packages:
  llvm-10-doc llvm-6.0-doc python3-doc python3-tk python3-venv python3-setuptools ttf-bitstream-vera python3.6-venv
  python3.6-doc binutils readline-doc
The following NEW packages will be installed:
  binfmt-support file libclang-cpp10 libedit2 libexpat1 libffi-dev libgomp1 libjsoncpp1 libllvm10 libllvm6.0
  libmagic-mgc libmagic1 libmpdec2 libpfm4 libpipeline1 libpython3-stdlib libpython3.6-minimal libpython3.6-stdlib
  libreadline7 libsqlite3-0 libssl1.1 libtinfo-dev libyaml-0-2 libz3-4 libz3-dev llvm llvm-10 llvm-10-dev
  llvm-10-runtime llvm-10-tools llvm-6.0 llvm-6.0-dev llvm-6.0-runtime llvm-dev llvm-runtime mime-support python3
  python3-minimal python3-pkg-resources python3-pygments python3-yaml python3.6 python3.6-minimal readline-common
  xz-utils
0 upgraded, 45 newly installed, 0 to remove and 1 not upgraded.
root@9b7cdaa9581a:/# apt install llvm-10-dev
The following additional packages will be installed:
  binfmt-support file libclang-cpp10 libedit2 libexpat1 libffi-dev libgomp1 libllvm10 libmagic-mgc libmagic1 libmpdec2
  libpfm4 libpipeline1 libpython3-stdlib libpython3.6-minimal libpython3.6-stdlib libreadline7 libsqlite3-0 libssl1.1
  libtinfo-dev libyaml-0-2 libz3-4 libz3-dev llvm-10 llvm-10-runtime llvm-10-tools mime-support python3
  python3-minimal python3-pkg-resources python3-pygments python3-yaml python3.6 python3.6-minimal readline-common
  xz-utils
Suggested packages:
  llvm-10-doc python3-doc python3-tk python3-venv python3-setuptools ttf-bitstream-vera python3.6-venv python3.6-doc
  binutils readline-doc
The following NEW packages will be installed:
  binfmt-support file libclang-cpp10 libedit2 libexpat1 libffi-dev libgomp1 libllvm10 libmagic-mgc libmagic1 libmpdec2
  libpfm4 libpipeline1 libpython3-stdlib libpython3.6-minimal libpython3.6-stdlib libreadline7 libsqlite3-0 libssl1.1
  libtinfo-dev libyaml-0-2 libz3-4 libz3-dev llvm-10 llvm-10-dev llvm-10-runtime llvm-10-tools mime-support python3
  python3-minimal python3-pkg-resources python3-pygments python3-yaml python3.6 python3.6-minimal readline-common
  xz-utils
0 upgraded, 37 newly installed, 0 to remove and 1 not upgraded.

I'd suggest using both more up-to-date and specific version of the package (llvm-10-dev).
I've run workflow on these changes and it compiles without errors. Although I'm unable to test IOS and aarch64 builds as these require self-hosted runner.

Removed apt instructions for metapackages clang and llvm in favor of specific version package
@easymoney322
Copy link
Contributor Author

I also checked run-flutter-nightly-build / build rustdesk android apk aarch64-linux-android and it looks like on ubuntu 20.04 it resolves to the same package.

@rustdesk
Copy link
Owner

Thanks

@rustdesk rustdesk merged commit 4e5dcd8 into rustdesk:master May 14, 2024
18 checks passed
@easymoney322 easymoney322 deleted the llvm-10 branch May 16, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants