Upgrade to bitflags v2 #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bitflags v2 has an MSRV of Rust 1.56.0: https://crates.io/crates/bitflags/2.0.0 |
Prepare for v6.5.0 release. As a compatibility note, bitflags v2 does not generate a `from_bits_unchecked` method. See the "major changes" section of the release notes: https://github.com/bitflags/bitflags/releases/tag/2.0.0 I consider this breakage to be minor and not worth a major version bump, but I'm happy to rev the `onig` crate to 7.0.0 if you'd prefer. I'd appreciate getting this released. `onig` is one of the last crates in my lockfile that hasn't yet upgraded to `bitflags` v2.
lopopolo
force-pushed
the
lopopolo/bitflags-v2
branch
from
13cf021
to
773c733
Compare
|
MSRV is further bumped to 1.60.0 for regex and 1.63.0 for rustix to get a green build |
|
@iwillspeak gentle bump on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for v6.5.0 release.
As a compatibility note, bitflags v2 does not generate a
from_bits_uncheckedmethod. See the "major changes" section of the release notes: https://github.com/bitflags/bitflags/releases/tag/2.0.0I consider this breakage to be minor and not worth a major version bump, but I'm happy to rev the
onigcrate to 7.0.0 if you'd prefer.I'd appreciate getting this released.
onigis one of the last crates in my lockfile that hasn't yet upgraded tobitflagsv2.