Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement space_after_not option #6050

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

x17jiri
Copy link

@x17jiri x17jiri commented Jan 31, 2024

There has been request for this some time ago #5308

I would also like to have this option

@ytmimi
Copy link
Contributor

ytmimi commented Feb 18, 2024

Thanks for the PR. Going to mark this one as on hold for now. There was some discussion back in #5308, where we were unsure if we should add this option. Again, I want to thank you for stepping up to work on this. We'll follow up once we've had a chance to discuss this one.

@x17jiri
Copy link
Author

x17jiri commented Feb 22, 2024

@ytmimi Sure. Is there something I can help with in the meantime?

@ytmimi
Copy link
Contributor

ytmimi commented Feb 22, 2024

@x17jiri not at this time. This is something that the team needs to discuss to unblock. I brought this up for discussion in our last team meeting, but it hasn't been addressed yet because the team couldn't meet at the scheduled time. The discussion might continue on the linked thread, but if it doesn't I'll do my best to bring this one up again during our next team meeting

@ytmimi
Copy link
Contributor

ytmimi commented Feb 22, 2024

@ytmimi Sure. Is there something I can help with in the meantime?

@x17jiri my last comment was referring to this one being blocked until the team has a chance to discuss this, but I'm now realizing that maybe you were asking about helping out with other issues. If that's the case, then I'm sure I could point you in the right direction!

@x17jiri
Copy link
Author

x17jiri commented Feb 22, 2024

@ytmimi

my last comment was referring to this one being blocked until the team has a chance to discuss this, but I'm now realizing that maybe you were asking about helping out with other issues. If that's the case, then I'm sure I could point you in the right direction!

Yes, that's what I meant :-)

@ytmimi
Copy link
Contributor

ytmimi commented Feb 22, 2024

Yes, that's what I meant :-)

Fantastic! I'll dig through the backlog when I've got a little more free time and tag you in one or two issues that I think would be a good fit for a new contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants