Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In macro definitions new name can start from $ without spaces before it. #6030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rscprof
Copy link

@rscprof rscprof commented Jan 17, 2024

5905

Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustfmt doesn't really support formatting macros that use repetition. I'm wondering if it's possible to leverage MacroArgKind and return None before we even call replace_names.

@ytmimi
Copy link
Contributor

ytmimi commented Jan 17, 2024

@rscprof I also want to say thanks for another PR 🙏🏼! I see you've opened several recently. Out of curiosity, are these issues that you're trying to fix because you've run into these yourself or are you just trying to pick up tickets that interest you?

We have quite the backlog of PRs, and some of the issues you've opened PRs for are low priority, so just a fair warning that it might be a while before Caleb or I has a chance to review the work you've done.

@rscprof
Copy link
Author

rscprof commented Jan 17, 2024

@rscprof I also want to say thanks for another PR 🙏🏼! I see you've opened several recently. Out of curiosity, are these issues that you're trying to fix because you've run into these yourself or are you just trying to pick up tickets that interest you?

We have quite the backlog of PRs, and some of the issues you've opened PRs for are low priority, so just a fair warning that it might be a while before Caleb or I has a chance to review the work you've done.

I'm just practicing rust and do something good for another people while I can. Now I just get issues with label "bug" if this issue don't have related pull-request or assignees.

@rscprof
Copy link
Author

rscprof commented Jan 17, 2024

rustfmt doesn't really support formatting macros that use repetition. I'm wondering if it's possible to leverage MacroArgKind and return None before we even call replace_names.

I have seen it. I just add minimal thing that repair case in issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants