Only allow immutable statics with #[linkage] #125046
Merged
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
no_mutable_static_linkage
branch
from
e4a404a
to
88b27eb
Compare
| @@ -327,6 +327,10 @@ fn codegen_fn_attrs(tcx: TyCtxt<'_>, did: LocalDefId) -> CodegenFnAttrs { | |||
| } else { | |||
| codegen_fn_attrs.linkage = linkage; | |||
| } | |||
| if tcx.is_mutable_static(did.into()) { | |||
| tcx.dcx() | |||
| .span_err(attr.span, "mutable statics are not allowed with #[linkage]"); | |||
There was a problem hiding this comment.
Suggested change
| .span_err(attr.span, "mutable statics are not allowed with #[linkage]"); | |
| .span_err(attr.span, "mutable statics are not allowed with `#[linkage]`"); |
Also maybe worth while explaining why in a note, or linking to something that explains why.
bjorn3
force-pushed
the
no_mutable_static_linkage
branch
from
88b27eb
to
715d72f
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
force-pushed
the
no_mutable_static_linkage
branch
from
715d72f
to
531dae1
Compare
|
@rustbot ready |
|
Should this be considered as a breaking change that requires t-lang signoff, or as something that has never worked ever? |
|
|
|
Indeed. |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
May 26, 2024
…r=cjgillot Only allow immutable statics with #[linkage]
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#125046 (Only allow immutable statics with #[linkage]) - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity) - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125535 (clean-up: remove deprecated field `dist.missing-tools`) - rust-lang#125539 (crashes: increment the number of tracked ones) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too) - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2024
…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#125046 (Only allow immutable statics with #[linkage]) - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity) - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion) - rust-lang#125530 (cleanup dependence of `ExtCtxt` in transcribe when macro expansion) - rust-lang#125535 (clean-up: remove deprecated field `dist.missing-tools`) - rust-lang#125539 (crashes: increment the number of tracked ones) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too) - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify) r? `@ghost` `@rustbot` modify labels: rollup
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 26, 2024
…r=cjgillot Only allow immutable statics with #[linkage]
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 26, 2024
…r=cjgillot Only allow immutable statics with #[linkage]
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 27, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#124048 (Support C23's Variadics Without a Named Parameter) - rust-lang#125046 (Only allow immutable statics with #[linkage]) - rust-lang#125466 (Don't continue probing for method if in suggestion and autoderef hits ambiguity) - rust-lang#125469 (Don't skip out of inner const when looking for body for suggestion) - rust-lang#125544 (Also mention my-self for other check-cfg docs changes) - rust-lang#125559 (Simplify the `unchecked_sh[lr]` ub-checks a bit) - rust-lang#125566 (Notify T-rustdoc for beta-accepted and stable-accepted too) - rust-lang#125582 (Avoid a `FieldIdx::from_usize` in InstSimplify) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 27, 2024
Rollup merge of rust-lang#125046 - bjorn3:no_mutable_static_linkage, r=cjgillot Only allow immutable statics with #[linkage]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.