Verify build-std resolve against original lockfile #13916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
A-dependency-resolution
|
r? @ehuss (nvm, I forgot a file 🙃) |
Co-authored-by: Lawrence Tang <lawrence.tang@arm.com>
adamgemmell
force-pushed
the
dev/adagem01/verify-std-lock
branch
from
4f5aa4d
to
eda17f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Ensures that the resolve of the standard library when using build-std is a subset of the lockfile from the library source, as per discussion on rust-lang/wg-cargo-std-aware#38. It is a runtime version of the test added here: #13404
Fixes rust-lang/wg-cargo-std-aware#38
How should we test and review this PR?
It can be manually tested by running cargo build -Zbuild-std --target=[host] and seeing the command succeed. I'm not sure what behaviour can exercise the negative test case.
Additional information
Co-authored-by: Lawrence Tang lawrence.tang@arm.com