Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VectorStore -> BasePydanticVectorStore, also get/delete_nodes, clear() #13439

Merged
merged 27 commits into from May 14, 2024

Conversation

logan-markewich
Copy link
Collaborator

  • Migrates all remaining vector stores to pydantic base class
  • Updates typing
  • Add new get/delete_nodes() and clear() methods
  • Implement new methods some simple, qdrant, and chroma
  • add tests for simple, qdrant, and chroma

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 11, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nerdai
Copy link
Contributor

nerdai commented May 11, 2024

Nice! I'm just getting caught up with #13352 which I think needs this, right?

@logan-markewich
Copy link
Collaborator Author

@nerdai yea, in order to make that less janky, the new methods here will be very helpful

Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to deprecate VectorStore now in favour of BasePydanticVectorStore?

@logan-markewich
Copy link
Collaborator Author

@nerdai yes -- every vector store should use the pydantic base class yet. I kept the old one in the code in case anyone was importing and subclassing it though

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 13, 2024
@logan-markewich logan-markewich merged commit b9f8085 into main May 14, 2024
8 checks passed
@logan-markewich logan-markewich deleted the logan/vector_store_upgrades branch May 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants