New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VectorStore -> BasePydanticVectorStore, also get/delete_nodes, clear() #13439
Conversation
logan-markewich
commented
May 11, 2024
- Migrates all remaining vector stores to pydantic base class
- Updates typing
- Add new get/delete_nodes() and clear() methods
- Implement new methods some simple, qdrant, and chroma
- add tests for simple, qdrant, and chroma
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Nice! I'm just getting caught up with #13352 which I think needs this, right? |
@nerdai yea, in order to make that less janky, the new methods here will be very helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to deprecate VectorStore
now in favour of BasePydanticVectorStore
?
@nerdai yes -- every vector store should use the pydantic base class yet. I kept the old one in the code in case anyone was importing and subclassing it though |