New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alibaba cloud Bailian index intergration #13378
base: main
Are you sure you want to change the base?
Add Alibaba cloud Bailian index intergration #13378
Conversation
…lop_llama-index-node-parser-relational-dashscope
…lop_llama-index-node-parser-relational-dashscope
…lop_llama-index-node-parser-relational-dashscope
…lop_llama-index-node-parser-relational-dashscope
…lational-dashscope
…f github.com:PhantomGrapes/llama_index into intergration_bailian_cloud_index
Can anyone review my PR? I've been waiting for 2 weeks. @logan-markewich @nerdai |
Anyone can review my PR? Or tell me why my PR can't get reviewed. @logan-markewich @sourabhdesai @Disiok @EmanuelCampos |
Its been one week, and its been busy to review such a large PR 😅 |
...indices/llama-index-indices-managed-dashscope/llama_index/indices/managed/dashscope/utils.py
Outdated
Show resolved
Hide resolved
...ama-index-indices-managed-dashscope/llama_index/indices/managed/dashscope/transformations.py
Outdated
Show resolved
Hide resolved
.../indices/llama-index-indices-managed-dashscope/llama_index/indices/managed/dashscope/base.py
Outdated
Show resolved
Hide resolved
.../indices/llama-index-indices-managed-dashscope/llama_index/indices/managed/dashscope/base.py
Outdated
Show resolved
Hide resolved
.../indices/llama-index-indices-managed-dashscope/llama_index/indices/managed/dashscope/base.py
Outdated
Show resolved
Hide resolved
...egrations/node_parser/relational/llama-index-node-parser-relational-dashscope/pyproject.toml
Outdated
Show resolved
Hide resolved
...egrations/node_parser/relational/llama-index-node-parser-relational-dashscope/pyproject.toml
Outdated
Show resolved
Hide resolved
llama-index-integrations/readers/llama-index-readers-dashscope/README.md
Show resolved
Hide resolved
...x-integrations/node_parser/relational/llama-index-node-parser-relational-dashscope/README.md
Outdated
Show resolved
Hide resolved
llama-index-integrations/indices/llama-index-indices-managed-dashscope/README.md
Show resolved
Hide resolved
...-index-node-parser-relational-dashscope/llama_index/node_parser/relational/dashscope/base.py
Outdated
Show resolved
Hide resolved
...-index-node-parser-relational-dashscope/llama_index/node_parser/relational/dashscope/base.py
Outdated
Show resolved
Hide resolved
llama-index-integrations/readers/llama-index-readers-dashscope/pyproject.toml
Outdated
Show resolved
Hide resolved
llama-index-integrations/indices/llama-index-indices-managed-dashscope/pyproject.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments.
Also, up to you, but it's probably worth writing some unit tests? Some of these integrations are pretty complicated
Since the test need API key on DashScope Cloud, we are unable to put it in unit tests publicly. We test it locally before commit. |
Head branch was pushed to by a user without write access
I added BUILD files to fix |
Description
Alibaba cloud Bailian (Dashscope) is a platform for developing LLM based applications including RAG. We add a set of LlamaIndex intergrations including Parse, Node Parser, Index&Retriever for our platform.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods