Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alibaba cloud Bailian index intergration #13378

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

PhantomGrapes
Copy link

Description

Alibaba cloud Bailian (Dashscope) is a platform for developing LLM based applications including RAG. We add a set of LlamaIndex intergrations including Parse, Node Parser, Index&Retriever for our platform.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 9, 2024
@PhantomGrapes
Copy link
Author

Can anyone review my PR? I've been waiting for 2 weeks. @logan-markewich @nerdai

@PhantomGrapes
Copy link
Author

Anyone can review my PR? Or tell me why my PR can't get reviewed. @logan-markewich @sourabhdesai @Disiok @EmanuelCampos

@logan-markewich
Copy link
Collaborator

Its been one week, and its been busy to review such a large PR 😅

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

Also, up to you, but it's probably worth writing some unit tests? Some of these integrations are pretty complicated

@PhantomGrapes
Copy link
Author

Just a few minor comments.

Also, up to you, but it's probably worth writing some unit tests? Some of these integrations are pretty complicated

Since the test need API key on DashScope Cloud, we are unable to put it in unit tests publicly. We test it locally before commit.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 22, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) May 22, 2024 00:45
auto-merge was automatically disabled May 23, 2024 03:32

Head branch was pushed to by a user without write access

@PhantomGrapes
Copy link
Author

I added BUILD files to fix tailor failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants