Add New Integration for DeepInfra Embedding Model #13323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add New Integration for DeepInfra Embedding Model
dosubot
bot
added
the
size:L
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| """ | ||
| self._model_id = model_id | ||
| self._normalize = normalize | ||
| self._api_token = os.getenv(ENV_VARIABLE, api_token) |
There was a problem hiding this comment.
shouldn't this be api_token or os.getenv(..) ? Otherwise it ignores the api key in the constructor
There was a problem hiding this comment.
Yes that makes sense. Thanks for the feedback.
| self._text_prefix = text_prefix | ||
| self._batch_size = batch_size | ||
|
|
||
| super().__init__(callback_manager=callback_manager) |
There was a problem hiding this comment.
Normally I would call super first
| self._api_token = os.getenv(ENV_VARIABLE, api_token) | ||
| self._query_prefix = query_prefix | ||
| self._text_prefix = text_prefix | ||
| self._batch_size = batch_size |
There was a problem hiding this comment.
There is already a parameter on the parent class for this embed_batch_size -- we should use that instead
There was a problem hiding this comment.
@logan-markewich Thanks for your feedback.
fix(api_token): argument is more prior to the environment
logan-markewich
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new integration for the DeepInfra Inference API.
Motivation and Context
Users are able to use DeepInfra's models using llama_index.
Fixes
New Package?
If yes, I have filled in the
tool.llamahubsection in thepyproject.tomland provided a detailedREADME.mdfor my new integration.Version Bump?
Type of Change
How Has This Been Tested?
Suggested Checklist:
make format; make lintto appease the lint gods