[rust gem] Major improvements for gem scaffolding #7608
Conversation
ianks
force-pushed
the
cargo-test-work-by-default
branch
from
5537262
to
f483e2c
Compare
hsbt
force-pushed
the
cargo-test-work-by-default
branch
from
f483e2c
to
b090e96
Compare
|
@ianks this looks amazing. I did some local testing and I have faced following problem. $ ~/code/work/oss/rubygems/bundler/exe/bundle gem --ext=rust ryba
...
$ cd ryba
$ cargo test
...
Compiling rb-sys-build v0.9.97
Compiling rb-sys v0.9.97
Finished test [unoptimized + debuginfo] target(s) in 27.65s
Running unittests src/lib.rs (target/debug/deps/ryba-715184ccf66f2799)
running 1 test
/tmp/ryba/target/debug/deps/ryba-715184ccf66f2799: symbol lookup error: /home/retro/.rubies/ruby-3.3.1/lib/ruby/3.3.0/x86_64-linux/enc/encdb.so: undefined symbol: rb_encdb_declare
error: test failed, to rerun pass `--lib`
Caused by:
process didn't exit successfully: `/tmp/ryba/target/debug/deps/ryba-715184ccf66f2799` (exit status: 127)Is that anything related to my setup? 🤔 Similar error seems to fail CI (https://github.com/rubygems/rubygems/actions/runs/9014478174/job/24767239926?pr=7608). |
|
hmm that's strange @simi, are you on linux? |
| # Fall back to loading the non-versioned extension if version-specific loading fails. | ||
| begin | ||
| RUBY_VERSION =~ /(\d+\.\d+)/ | ||
| require "#{Regexp.last_match(1)}/<%= File.basename(config[:namespaced_path]) %>/<%= config[:underscored_name] %>" |
There was a problem hiding this comment.
This is something users frequently stumble on when trying to precompile gems, so let's just use the recommended pattern by rake-compiler as a default: https://github.com/rake-compiler/rake-compiler?tab=readme-ov-file#cross-compilation---the-future-is-now
| @@ -41,7 +37,7 @@ Gem::Specification.new do |spec| | |||
| spec.extensions = ["ext/<%= config[:underscored_name] %>/extconf.rb"] | |||
| <%- end -%> | |||
| <%- if config[:ext] == 'rust' -%> | |||
| spec.extensions = ["ext/<%= config[:underscored_name] %>/Cargo.toml"] | |||
| spec.add_dependency "rb_sys", "~> 0.9" | |||
There was a problem hiding this comment.
The CargoBuilder was a good first start, but it's much less flexible and not the best default IMO. rb-sys + create_rust_makefile is much more robust these days, so let's use it
| @@ -12,4 +12,11 @@ publish = false | |||
| crate-type = ["cdylib"] | |||
|
|
|||
| [dependencies] | |||
| magnus = { version = "0.6.2" } | |||
| magnus = { version = "0.6.3" } | |||
| rb-sys = { version = "0.9", features = ["stable-api-compiled-fallback"] } | |||
There was a problem hiding this comment.
With this, we support ruby-head out of the box. This allows users to run development/unstable rubies in production without friction
ianks
force-pushed
the
cargo-test-work-by-default
branch
from
8c4d73d
to
37a8c8b
Compare
ianks
force-pushed
the
cargo-test-work-by-default
branch
from
37a8c8b
to
ac358f4
Compare
ianks
changed the title
ianks
force-pushed
the
cargo-test-work-by-default
branch
from
d6d7443
to
bea50ba
Compare
Yes! $ uname -a
Linux retro 6.8.10-300.fc40.x86_64 #1 SMP PREEMPT_DYNAMIC Fri May 17 21:20:54 UTC 2024 x86_64 GNU/Linux |
|
Confirmed that cross-compilation works out of the box: https://github.com/ianks/testingbun/actions/runs/9312563096 |
bundle gem --ext=rustresults in a project that doesn't supportcargo testby default. This causes unnecessary toil for developers who expect cargo test to work out of the box. This PR fixes that by usingrb-sys-envto configure the proper linker arguments for libruby.