-
-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timescaledb to infrastructure #4716
base: master
Are you sure you want to change the base?
Conversation
ports: | ||
- "5432:5432" | ||
timescale: | ||
image: timescale/timescaledb-ha:pg16.2-ts2.14.2-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is 1.5GB @jonatas, isn't there any small one suitable for development + CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there's a smaller one but does not contains the toolkit. Probably latest-pg16 already do the work. < 300MB.
image: timescale/timescaledb-ha:pg16.2-ts2.14.2-all | |
image: timescale/timescaledb:latest-pg16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link 404s, https://hub.docker.com/layers/timescale/timescaledb/latest-pg16. What's the toolkit useful for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toolkit can give extra flexibility in the components for statistics, containing several cool stuff like most of the hyperfunctions.
It allow us to use components like stats_agg that have some embeddings for several statistics, so you can extract stddev, average without recomputing everything. Percentile_agg do the same for distribution and allow you to get several discs without reprocessing. The coolest part is rollup that allows to merge this _agg objects and reuse pre-calculated data into bigger timeframes.
75d22ac
to
7b3f763
Compare
7b3f763
to
500297d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4716 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 394 394
Lines 8338 8338
=======================================
Hits 8100 8100
Misses 238 238 ☔ View full report in Codecov by Sentry. |
82aad05
to
f5d23aa
Compare
f5d23aa
to
d49e2de
Compare
ecdb6da
to
e4289ae
Compare
It relates to the very beginning of #4642.
Talking to @simi, we agreed on adding a basic setup to infra and incrementally be adding the remaining features. Nothing new here, just a fragment of previous work.
The POC is also available for those that are curious on how it will work.