Add rubygem_id foreign key constraint to linksets table. #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
force-pushed
the
linkset-foreign-key
branch
from
65f3bfc
to
02018b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4571 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 393 393
Lines 8321 8321
=======================================
Hits 8082 8082
Misses 239 239 ☔ View full report in Codecov by Sentry. |
martinemde
approved these changes
Apr 1, 2024
segiddins
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is 1 old linklist breaking this foreign key.
@martinemde @segiddins would you prefer to make the deletion in migration or is it ok to delete manually to keep prod DB inconsistency details out of migrations?