Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing straighforward foreign keys. #4561

Merged
merged 2 commits into from
May 31, 2024
Merged

Add missing straighforward foreign keys. #4561

merged 2 commits into from
May 31, 2024

Conversation

simi
Copy link
Member

@simi simi commented Mar 27, 2024

  • adding those should not casue any troubles data-wise in production
  • two-phased migration for no database write locks

@simi
Add missing straighforward foreign keys.
03eebf3 
- adding those should not casue any troubles data-wise in production
- two-phased migration for no database write locks
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (af87334) to head (dacfdad).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4561   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         393      393           
  Lines        8321     8321           
=======================================
  Hits         8082     8082           
  Misses        239      239

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi simi marked this pull request as ready for review March 27, 2024 14:42
martinemde
martinemde approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you already checked with production data. Thanks for going through these.

@simi simi enabled auto-merge (squash) May 31, 2024 18:33
@simi simi merged commit be98212 into master May 31, 2024
17 checks passed
@simi simi deleted the foreign-keys-1 branch May 31, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinemde martinemde martinemde approved these changes

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simi @martinemde @segiddins