Ripper DSL improvement #10766
Merged
Ripper DSL improvement #10766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
yui-knk
approved these changes
May 20, 2024
Ripper DSL uses these values for callbacks, but does not need indexes.
Now it is used only for wheter `opt_paren_args` is `none`. Introduce a new special node to distinguish an empty parentheses from it .
Prepare `path` as `$:$` before `const_decl` and update it there. Remove `ripper_const_decl` which is no longer used.
Prepare `lhs` as `$:$` before `assignable` and update it there. Remove `ripper_assignable` which is no longer used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$:nto refer each grammar valuesRipper DSL uses these values for callbacks, but does not need indexes.
[$:n, ...]which enclose values in an array.$:n[i]and sub-array$:n[i..j]to splat.Since Ripper does not know the length, it needs to index with a range to tell the length.
rb_ripper_noneobject.