Memory optimisation & rubocop on tests #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkellogg
reviewed
Apr 18, 2023
| # Skip term if `@prefix` is not true in term definition | ||
| next unless td.prefix? | ||
| next unless td&.prefix? |
There was a problem hiding this comment.
Learn something new every day 😄
There was a problem hiding this comment.
Quite practical, isn't it?
|
There should probably either be a separate rubocop GH Action, or it should be added to .github/workflows/CI.yml. |
gkellogg
reviewed
Apr 18, 2023
| let(:reader_count) {doap_count} | ||
| end | ||
|
|
||
| describe ".for" do |
There was a problem hiding this comment.
Why remove these tests? are they redundant?
There was a problem hiding this comment.
It's a mistake, thanks for pointing it out. I have rebased the branch.
gkellogg
approved these changes
Apr 18, 2023
abrisse
force-pushed
the
feat/optimizations
branch
from
97fd59c
to
c9e4542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR improves the memory management. On my benchmark (JSON-LD framing) the memory allocation is reduced by 37%.
It contains minor code modifications on tests to fix some rubocop offenses.
Before
allocated memory by gem
83.70 MB json-ld
allocated memory by file
38.59 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/frame.rb
17.20 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/context.rb
15.30 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/flatten.rb
4.22 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/from_rdf.rb
3.48 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/utils.rb
After
allocated memory by gem
52.95 MB json-ld
allocated memory by file
20.53 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/frame.rb
13.39 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/context.rb
6.42 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/flatten.rb
4.22 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/from_rdf.rb
3.48 MB /home/aymeric/dev/gems/json-ld/lib/json/ld/utils.rb