fix(performance): comment all log_debug #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @gkellogg,
While investigating some memory issues I discovered that the
log_debug
calls generate a lot of objects. Half of them were already commented so this PR comments all the others.I did a small benchmark with memory_profiler:
The 3 lines that stores a lot of objects:
This is partly because the RDF utils functions
logger_debug
/logger_common
use splat operators which is quite costly, so I think the PR provide the best ROI.