-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show used columns in col_vals_expr()
#505
base: main
Are you sure you want to change the base?
Conversation
Apparently I'm trying to find a good way around this but the good thing is that this feature is purely a convenience of display in the agent report, so currently I have it failing gracefully in case of parsing errors (falls back to showing nothing for columns) and I'll think more about what I can do w.r.t. including it in (automated) tests. |
Summary
This PR aims to have
col_vals_expr()
show columns used inexpr
in the agent report. Example inspired by fn docs:This is a draft because it needs more tests.
Related GitHub Issues and PRs
get_agent_x_list()$columns
is empty forcol_vals_expr()
#477Checklist
testthat
unit tests totests/testthat
for any new functionality.