Rename library global from moment-range to MomentRange
#152
Conversation
karma.conf.js
Outdated
| @@ -24,6 +24,9 @@ module.exports = function(config) { | |||
| }, | |||
|
|
|||
| files: [ | |||
| { pattern: 'node_modules/expect.js/index.js', watched: false }, | |||
| { pattern: 'node_modules/moment/min/moment.min.js', watched: false }, | |||
| { pattern: 'dist/moment-range.js', watched: false }, | |||
There was a problem hiding this comment.
i don't think it's necessary to list the dependencies in the files key
There was a problem hiding this comment.
I didn't like to add the dependencies, but the test does not work without this.
Of course, I could define a second karma configuration especially for the browser test, if you think it's worth it.
| @@ -40,7 +40,7 @@ module.exports = { | |||
| }, | |||
| output: { | |||
| filename: 'moment-range.js', | |||
| library: 'moment-range', | |||
| library: 'MomentRange', | |||
There was a problem hiding this comment.
so, this'll change the name for all module types. ideally i'd like to keep it as moment-range everywhere except the browser
There was a problem hiding this comment.
Don't you specify file names for the import (ES6) or require (commonJS). In that case, I think the changed name should not effect these cases?
I could not find any option in the webpack configuration to specify the name for the browser case.
|
I created tests for commonjs and ES6, testing the documented usage for both cases. |
|
this should be merged for the |
gf3
changed the title
moment-range to MomentRange
The - character in the library name seems to confuse the browser.
I have added a testcase lib/browser_test.js that checks the expected behaviour as defined in issue 142 (but changed the library name from DateRange to MomentRange because I thought it's more approriate).
To fix the issue, I renamed the library from moment-range to MomentRange. The testcase lib/browser_test.js as well as a privately performed test in the browser showed that
MomentRange.extendMoment(moment);
is working now.
Please pull