renewal of the shiny interface #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2017 23:47
Added the possibility to pre-process thumbnails, which improves the speed if having to use locate_area on a large number of files
Thumbnails are named by their file of origin with page number as suffix. By default files are renamed such that the page suffix contains the same number of characters for all thumbnails (01,02,…,10,11). As a result the first thumbnail could either be called <somename>1.ext or <somename>01.ext or even <somename>001.ext, making it harder to pick up these files downstream. Here an option is added to change this behaviour so that the first thumbnail is always called <somename>1.ext
leeper
suggested changes
Jul 26, 2017
| @@ -53,9 +54,16 @@ function(file, pages = NULL, resolution = 60L, widget = c("shiny", "native", "re | |||
| file <- localize_file(file, copy = TRUE) | |||
| on.exit(unlink(file), add = TRUE) | |||
| dims <- get_page_dims(file, pages = pages) | |||
|
|
|||
| if (!is.null(thumbnails)){ | |||
| file.copy(filelist, tempdir(),overwrite=T) | ||
| paths <-file.path(tempdir(),basename(filelist)) | ||
| cat('fetching files') | ||
| } else if (is.null(thumbnails)){ |
| @@ -97,7 +105,7 @@ function(file, pages = NULL, resolution = 60L, widget = c("shiny", "native", "re | |||
| #' @rdname extract_areas | |||
| #' @export | |||
| extract_areas <- function(file, pages = NULL, guess = FALSE, ...) { | |||
| areas <- locate_areas(file = file, pages = pages) | |||
| areas <- locate_areas(file = file, pages = pages, thumbnails = NULL, resolution = 60L, widget = c("shiny", "native", "reduced")) | |||
| @@ -48,6 +49,6 @@ function(file, outdir = NULL, pages = NULL, format = c("png", "jpeg", "bmp", "gi | |||
| PDFImageWriter$writeImage(pdfDocument, format, "", pages[i], pages[i], | |||
| prefix, 1L, as.integer(resolution)) | |||
| } | |||
| file.rename(from = paste0(prefix, pages, ".", format), to = outfile) | |||
| ifelse(file.exists(outfile), outfile, NA_character_) | |||
| if(isTRUE(uniform)){file.rename(from = paste0(prefix, pages, ".", format), to = outfile) | |||
There was a problem hiding this comment.
Spread this out across multiple lines with spacing between brackets:
if (condition) {
code
}| @@ -6,6 +6,7 @@ | |||
| #' @param format A character string specifying an image file format. | |||
| #' @param resolution An integer specifying the image resolution in DPI. | |||
| #' @param password Optionally, a character string containing a user password to access a secured PDF. | |||
| #' @param uniform determines whether the page numbers suffixes of generated thumbnails have a uniform (01,02,...,10) or short (1,2,...,10) format. | |||
|
I will need to check the changes with tabula 1.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate renewal of the shiny interface two small changes were made to increase loading speed and predictability of thumbnails.