bug fixes package_create, package_update, package_patch #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bergert ! Sorry for the delay; I was on leave. having a look |
sckott
suggested changes
May 4, 2021
| *.Rproj | ||
| .Rbuildignore | ||
| .Rhistory | ||
| .Rproj.user/ |
There was a problem hiding this comment.
remove this line, it's a duplicate of above
| @@ -3,3 +3,7 @@ | |||
| .RData | |||
| .DS_Store | |||
| notes.md | |||
| *.Rproj | |||
| .Rbuildignore | |||
| .Rhistory | |||
.gitignore
Outdated
| @@ -3,3 +3,7 @@ | |||
| .RData | |||
| .DS_Store | |||
| notes.md | |||
| *.Rproj | |||
| .Rbuildignore | |||
There was a problem hiding this comment.
Remove this - we don't want to gitignore this file
R/package_create.R
Outdated
| body <- c(body, extras) | ||
| owner_org = owner_org,extras = extras)) | ||
|
|
||
| # if (length(extras) >0) { |
There was a problem hiding this comment.
please remove this commented out code and the blank line above it
|
closing to create new pull request |
you reopened the PR though. did you mean to close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug in fixes package_create, package_update, package_patch
Description
package_create: extras were not converted correctly to son, fixed API call
correct format: (extras = list(key="xx", value=1)
package_update: documentation is not correct: fixed
package_patch: body was not converted to son: fixed API call
Related Issue
I discovered these issues, while writing a script to update CKAN repository.
These are bugs to cause API calls to fail, cannot work without fixing.