Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slow multiprocessing #344

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix slow multiprocessing #344

wants to merge 8 commits into from

Conversation

riiswa
Copy link
Collaborator

@riiswa riiswa commented Jul 24, 2023 •
edited

Description

This PR refer to #329

  • Add regression test
  • Add torch.multiprocessing
  • Add regression test Add joblib manager ?

@riiswa riiswa marked this pull request as draft July 24, 2023 08:48
@omardrwch
Copy link
Member

omardrwch commented Jul 24, 2023 •
edited

Regarding "Replace multiprocessing by torch.multiprocessing", I wouldn't replace it, but add a "torch_multiprocessing" option (in AgentManager)

@riiswa
Copy link
Collaborator Author

riiswa commented Jul 24, 2023

@omardrwch okay I'll fix it

@riiswa riiswa marked this pull request as ready for review July 24, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@riiswa @omardrwch